Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

fix(codefix): correct hover information for type signatures with callbacks #415

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

danr
Copy link
Contributor

@danr danr commented Dec 5, 2017

Fixes #413

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          15       15           
  Lines        2038     2038           
  Branches      482      482           
=======================================
  Hits         1695     1695           
- Misses        341      343    +2     
+ Partials        2        0    -2
Impacted Files Coverage Δ
src/typescript-service.ts 85.15% <100%> (ø) ⬆️
src/match-files.ts 81.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f55da...aa760c3. Read the comment docs.

@felixfbecker
Copy link
Contributor

Could you add a test for this to prevent regressions?

@danr
Copy link
Contributor Author

danr commented Dec 5, 2017

I cannot read the output from tslint

@felixfbecker
Copy link
Contributor

Just run npm run prettier

@danr
Copy link
Contributor Author

danr commented Dec 5, 2017

Wohoo! 🎉

@felixfbecker felixfbecker merged commit 71f103d into sourcegraph:master Dec 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants